Avoids retrying on 403s - #123
Closed
emorell96 wants to merge 1 commit into
Closed
Conversation
emorell96
requested review from
budgetpreneur,
crimsonred and
mohitpubnub
as code owners
December 7, 2021 10:58
Contributor
|
We're sorry it took this long to address this PR but by now it's massively outdated and doesn't account for the internal Event Engine implementation. Also, retrying on 403 can be the desired behaviour since the auth token may have to be changed during runtime, and trying to perform a call with a stale one shouldn't terminate the connection. If this is still an issue please contact us again, but for now I'm closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a fix for retrying on 403s. From a consumer perspective retrying on 403s is extremely expensive since Pubnub charges per transaction even if it's a 403. So this fix that issue by checking the pnstatus and only retrying is the status is not AccessDeniedCategory.
If it is access denied category, then it announces it so that the user can implement its own retry logic.
Fixes: #122